-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom node-gyp for SDL pipeline #179723
Conversation
The VS Code Scan failed due to Binskim, which is currently being resolved elsewhere. |
Building the custom node-gyp is still good, so the CI passes those steps, but it fails in general because it's missing symbols, still. We can merge this PR in and wait for the symbols, or we can wait for the symbols first. |
Lets wait for the pdb files and get a green CI before merging. |
Pdb are now available starting with https://github.com/microsoft/vscode-electron-prebuilt/releases/tag/22.4.5, please rebase on top of |
ac1018c
to
d471966
Compare
Symbols are still not being downloaded. Looks like the scan gulp file might be a bit broken. Investigating. |
This took me way too long to figure out. |
👏 spectre flag is only raised for Electron related binaries and keytar as expected. I am good with the changes of this PR but lets wait for @joaomoreno who will be back on Monday and we can get a new version of |
We're now using SDL scan: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=211604&view=results |
No description provided.