Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows/Native Title Bar: Horrible Title Menu Experience #188757

Open
hediet opened this issue Jul 25, 2023 · 3 comments · Fixed by #188268
Open

Windows/Native Title Bar: Horrible Title Menu Experience #188757

hediet opened this issue Jul 25, 2023 · 3 comments · Fixed by #188268
Assignees
@deepak1556
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
Backlog

Comments

@hediet
Copy link
Member

hediet commented Jul 25, 2023 •
edited
Loading

Testing #188709

Notice how I cannot open the menu items to the right of the cursor (only to the left):
Code_-_Insiders_jecL4tl9xg

I used these settings:

"window.experimental.nativeContextMenuLocation": true,
"window.titleBarStyle": "native",
@bpasero bpasero assigned deepak1556 and rzhao271 and unassigned bpasero Jul 25, 2023
@bpasero
Copy link
Member

bpasero commented Jul 25, 2023 •
edited
Loading

This is one of the many reasons we actually implemented our own custom menu. The native one has a ton of issues - esp. around accessibility -, this only being one.

@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron titlebar VS Code main title bar issues confirmed Issue has been confirmed by VS Code Team member labels Jul 26, 2023
@deepak1556
Copy link
Collaborator

This is fixed in Exploration builds.

@deepak1556 deepak1556 added the fixed-in-electron-25 Issues fixed with Electron 25.x update label Jul 26, 2023
@deepak1556 deepak1556 added this to the August 2023 milestone Aug 7, 2023
@deepak1556 deepak1556 mentioned this issue Aug 7, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 7, 2023
@rzhao271 rzhao271 removed their assignment Aug 21, 2023
@hediet
Copy link
Member Author

hediet commented Aug 31, 2023

Doesn't look any better for me:

Code_-_Insiders_fzhJBPf4EH

@hediet hediet reopened this Aug 31, 2023
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Aug 31, 2023
@deepak1556 deepak1556 removed this from the August 2023 milestone Aug 31, 2023
@deepak1556 deepak1556 removed confirmed Issue has been confirmed by VS Code Team member fixed-in-electron-25 Issues fixed with Electron 25.x update labels Aug 31, 2023
@deepak1556 deepak1556 added this to the Backlog milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepak1556 deepak1556

Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

chore: update to Electron 25 microsoft/vscode
5 participants
@bpasero @deepak1556 @hediet @rzhao271 @vscodenpa