Don't reuse identifier with registerAction2

[jrieken]

I have noticed that some Action2 instances are registered that reuse an id. That's not OK because Action2 is a singleton model object, e.g it keybinding or menu registrations refer to it by id. This should be cleaned up and from then on it should be an error to reuse an id

• workbench.action.terminal.scrollToBottom @meganrogge @Tyriar
• workbench.action.terminal.scrollToTop @meganrogge @Tyriar
• workbench.scm.action.setListViewMode @lszomoru
• workbench.scm.action.setTreeViewMode @lszomoru
• fetch returns keybinding with user first if title and id matches @sandy081
• command 'toggleVisibility'
• command 'removeView'

[jrieken]

@sandy081 I believe this is all the same issue somewhere in views land?

[sandy081]

This is how these actions are registered

vscode/src/vs/workbench/services/views/browser/viewDescriptorService.ts

Line 808 in b4ab48b

id: `${viewDescriptor.id}.removeView`,

vscode/src/vs/workbench/services/views/browser/viewDescriptorService.ts

Line 775 in b4ab48b

id: `${viewDescriptor.id}.toggleVisibility`,

May I know what is the suggested approach?

[jrieken]

May I know what is the suggested approach?

Don't register them twice

[jrieken]

@sandy081 #202000 fixes duplication in view land by first disposing old action and only then creating new ones

[jrieken]

@Tyriar @lszomoru you are new to this issue, there are ids that are reused for Action2 and those need to be fixed. Today, this prints a warning but it this become an error soon

[jrieken]

Adding @meganrogge for @Tyriar