Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default width of notebook find widget is too small #209150

Closed
Tracked by #215397
rebornix opened this issue Mar 29, 2024 · 0 comments · Fixed by #216847
Closed
Tracked by #215397

Default width of notebook find widget is too small #209150

rebornix opened this issue Mar 29, 2024 · 0 comments · Fixed by #216847
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders notebook-find polish Cleanup and polish issue
Milestone

Comments

@rebornix
Copy link
Member

rebornix commented Mar 29, 2024

Type: Bug

The default width feels small, especially that we have 4 icons in the notebook find widget. It can only render 6 characters and then truncate.

image

VS Code version: Code - Insiders 1.88.0-insider (aa25485, 2024-03-28T22:10:25.599Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info
Item Value
CPUs AMD Ryzen 5 7600X 6-Core Processor (12 x 4700)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 31.16GB (8.48GB free)
Process Argv --enable-proposed-api ms-vscode.dscopilot-agent --enable-proposed-api ms-toolsai.datawrangler --crash-reporter-id acfa600b-65c9-4131-81cf-ad8200ffb7d3
Screen Reader no
VM 0%
Extensions (27)
Extension Author (truncated) Version
esbuild-problem-matchers con 0.0.3
vscode-eslint dba 2.4.4
vscode-deno den 3.36.0
gitlens eam 2024.3.2805
EditorConfig Edi 0.16.4
prettier-vscode esb 10.4.0
copilot Git 1.176.0
copilot-chat Git 0.14.2024032701
vscode-pull-request-github Git 0.85.2024032704
vscode-mocha-test-adapter hbe 2.14.1
vscode-test-explorer hbe 2.21.1
vscode-dotnet-runtime ms- 2.0.3
black-formatter ms- 2024.1.10861010
debugpy ms- 2024.2.0
isort ms- 2023.10.1
python ms- 2024.3.10871011
vscode-pylance ms- 2024.3.102
datawrangler ms- 0.29.6
jupyter ms- 2024.3.2024032701
jupyter-keymap ms- 1.1.2
jupyter-renderers ms- 1.0.17
vscode-jupyter-cell-tags ms- 0.1.8
vscode-jupyter-slideshow ms- 0.1.5
remote-containers ms- 0.353.0
extension-test-runner ms- 0.0.6
test-adapter-converter ms- 0.1.9
vscode-github-issue-notebooks ms- 0.0.130
A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
vsaa593:30376534
py29gd2263:30784851
vscaat:30438846
c4g48928:30535728
962ge761:30841072
pythongtdpath:30726887
welcomedialogc:30812479
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30926734
pyreplss1:30879911
pythonmypyd1:30859725
pythoncet0:30859736
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
bf62j303:30968145
cppperfnew:30980852
d34g3935:30961436
fegfb526:30952798
bg6jg535:30979844
ccp2r3:30958153
pythonait:30973460
gee8j676:30988845
g1icg217:30999571

@rebornix rebornix self-assigned this Mar 29, 2024
@rebornix rebornix added polish Cleanup and polish issue notebook-find labels Mar 29, 2024
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 21, 2024
@vscodenpa vscodenpa added this to the June 2024 milestone Jun 21, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 24, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders notebook-find polish Cleanup and polish issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants