Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor placeholder multiline text - use ellipsis instead #211403

Open
roblourens opened this issue Apr 26, 2024 · 4 comments · Fixed by #219566
Open

Editor placeholder multiline text - use ellipsis instead #211403

roblourens opened this issue Apr 26, 2024 · 4 comments · Fixed by #219566
Assignees
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality verification-found Issue verification failed verification-needed Verification of issue is requested

Comments

@roblourens
Copy link
Member

First, I'm not sure I like the placeholder pushing the chat input to multiple lines. And this differs from the decoration that I use in the case where there is other text in the input (#208976 (comment))

Also, the editor height doesn't react quite properly to text changes, see the recording

Recording 2024-04-25 at 19 17 21

@roblourens
Copy link
Member Author

Tacking onto this, there is already a placeholder color defined, input.placeholderForeground, but this is using the ghost text color.

@hediet hediet added feature-request Request for new features or functionality editor-core Editor basic functionality labels Apr 26, 2024
@hediet hediet added this to the May 2024 milestone Apr 26, 2024
@roblourens
Copy link
Member Author

@daviddossett agreed that the chat input shouldn't grow, but should overflow with .... That is something that is hard to implement with a decoration, but might be hard for you to implement too. But it would look nicer than what we do now, which is the text just running into the submit button and getting cut off.

@hediet hediet modified the milestones: May 2024, June 2024 May 27, 2024
@hediet hediet changed the title Editor placeholder multiline text Editor placeholder multiline text - use ellipsis instead Jun 6, 2024
@hediet
Copy link
Member

hediet commented Jun 6, 2024

Verification steps:

  • Open Playground example.
  • Notice the scrollbar and missing ellipsis
  • Chose the newest nightly monaco editor version
  • Verify that there is an ellipsis

@hediet hediet modified the milestones: June 2024, July 2024 Jun 25, 2024
hediet added a commit that referenced this issue Jul 1, 2024
@hediet hediet mentioned this issue Jul 1, 2024
hediet added a commit that referenced this issue Jul 1, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 1, 2024
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this issue Jul 10, 2024
@hediet hediet added the verification-needed Verification of issue is requested label Jul 23, 2024
@lramos15 lramos15 added the verified Verification succeeded label Jul 23, 2024
@lramos15
Copy link
Member

Image

Not sure if I'm doing something wrong but I don't see ellipses even on latest monaco playground. Will reopen for now since steps are already provided

@lramos15 lramos15 reopened this Jul 23, 2024
@lramos15 lramos15 added verification-found Issue verification failed and removed verified Verification succeeded labels Jul 23, 2024
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Jul 23, 2024
@hediet hediet removed this from the July 2024 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality verification-found Issue verification failed verification-needed Verification of issue is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants