Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Multi select for editor tabs #213550

Closed
2 tasks done
benibenj opened this issue May 27, 2024 · 3 comments
Closed
2 tasks done

Test: Multi select for editor tabs #213550

benibenj opened this issue May 27, 2024 · 3 comments

Comments

@benibenj
Copy link
Contributor

benibenj commented May 27, 2024

Refs: #119327

Complexity: 4

Create Issue


This month we added support for selecting multiple editor tabs and running some action with them.

How it works:

  • Ctrl + Click a tab: Opens the editor as active and the previous opened tab is selected. If it was selected, it unselects the tab if possible.
  • Ctrl + Shift a tab: Opens the editor as active and selects all editors between the the Anchor editor and the new active tab.
    • The Anchor editor is the last tab which a user Ctrl + Click to add to the current selection. If the user has only has not pressed Ctrl+Click during with the current selection, then the active editor is the Anchor editor

With Ctrl + Click:
Image

With Shift + Click:
Image

Testing:

  • Select multiple tabs and move them around in the same group
  • Select multiple tabs and move them out into a new group/window
  • Select multiple tabs and right click on one of them. Run some of the actions available in the context menu.
  • Select multiple tabs and press Ctrl + W which should close the selected tabs
@Thaina
Copy link

Thaina commented Jun 6, 2024

Is it possible to also indicate multi selected tab in explorer and opened, sync the selected item everywhere?

image

Something like this?

image

@benibenj
Copy link
Contributor Author

benibenj commented Jun 7, 2024

@Thaina Please please create a feature request for this. It is something we considered, but it's very tricky to solve when a user has multiple editor groups. Also, I'm not to sure about syncing with the explorer as it's possible to select a file which is not currently open, so that could lead to some unexpected behaviour

@Thaina
Copy link

Thaina commented Jun 8, 2024

@benibenj I would like to ask, is it possible or is it have any reason to not do this, or is it intentional to make it like this, or it actually should be and is a bug, before creating the issue for feature request

Your argument about file outside of workspace is also a great counter argument for this

@microsoft microsoft locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants