Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use CTX_INLINE_CHAT_HAS_AGENT for notebook or terminal chat #215526

Closed
jrieken opened this issue Jun 14, 2024 · 1 comment
Closed

Don't use CTX_INLINE_CHAT_HAS_AGENT for notebook or terminal chat #215526

jrieken opened this issue Jun 14, 2024 · 1 comment
Assignees
@meganrogge
Labels
debt Code quality issues terminal-chat Issues related to the terminal chat widget
Milestone
June 2024

Comments

@jrieken
Copy link
Member

jrieken commented Jun 14, 2024

The CTX_INLINE_CHAT_HAS_AGENT context key used in terminal and notebook chat which is wrong because it signals that there is a chat participant for the editor location and it doesn't know anything about other locations.
@meganrogge meganrogge added debt Code quality issues terminal-chat Issues related to the terminal chat widget labels Jun 14, 2024
@meganrogge meganrogge added this to the June 2024 milestone Jun 14, 2024
meganrogge added a commit that referenced this issue Jun 14, 2024
@meganrogge
terminal part of #215526
f78065c
@meganrogge meganrogge mentioned this issue Jun 14, 2024
Merged
meganrogge added a commit that referenced this issue Jun 18, 2024
@meganrogge
add hasChatAgent context key for terminal (#215554)
6f28d7f 
terminal part of #215526
rebornix added a commit that referenced this issue Jun 18, 2024
@rebornix
re #215526. move off inline chat context key in notebook
bd251d3
rebornix added a commit that referenced this issue Jun 18, 2024
@rebornix
re #215526. move off inline chat context key in notebook
f0edc07
@rebornix
Copy link
Member

It's now removed from the notebook side.

@rebornix rebornix removed their assignment Jun 18, 2024
bricefriha pushed a commit to bricefriha/vscode that referenced this issue Jun 26, 2024
@meganrogge @bricefriha
add hasChatAgent context key for terminal (microsoft#215554)
4454296 
terminal part of microsoft#215526
bricefriha pushed a commit to bricefriha/vscode that referenced this issue Jun 26, 2024
@rebornix @bricefriha
re microsoft#215526. move off inline chat context key in notebook
5dca69c
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
debt Code quality issues terminal-chat Issues related to the terminal chat widget
Projects
None yet
Milestone
June 2024
Development

No branches or pull requests
3 participants
@rebornix @jrieken @meganrogge