Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IChatTask can't be serialized #217645

Open
roblourens opened this issue Jun 25, 2024 · 0 comments
Open

IChatTask can't be serialized #217645

roblourens opened this issue Jun 25, 2024 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug chat debt Code quality issues
Milestone

Comments

@roblourens
Copy link
Member

IChatTask:

class MainThreadChatTask implements IChatTask {

is a class with methods that don't get serialized, so the interface is inaccurate after reloading the window, and that caused some issues while trying to refactor things. We should figure out how to set this up so that the types are correct after it's deserialized. Maybe we can push a full object with methods to the model, but when reading the chat response value, you get a different simpler interface. Or maybe we need some custom deserialization logic for some types.

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug chat labels Jun 25, 2024
@roblourens roblourens added this to the July 2024 milestone Jun 25, 2024
roblourens added a commit that referenced this issue Jun 25, 2024
roblourens added a commit that referenced this issue Jun 25, 2024
bricefriha pushed a commit to bricefriha/vscode that referenced this issue Jun 26, 2024
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this issue Jul 10, 2024
@roblourens roblourens modified the milestones: July 2024, August 2024 Jul 24, 2024
@joyceerhl joyceerhl modified the milestones: August 2024, September 2024 Aug 27, 2024
@joyceerhl joyceerhl added the debt Code quality issues label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug chat debt Code quality issues
Projects
None yet
Development

No branches or pull requests

2 participants