Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook metadata displayed as modified when a cell is added/deleted #230280

Closed
DonJayamanne opened this issue Oct 2, 2024 · 0 comments · Fixed by #230281
Closed

Notebook metadata displayed as modified when a cell is added/deleted #230280

DonJayamanne opened this issue Oct 2, 2024 · 0 comments · Fixed by #230281
Assignees
@DonJayamanne
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook notebook-diff verified Verification succeeded
Milestone
October 2024

Comments

@DonJayamanne
Copy link
Contributor

  • Create a notebook
  • Add a cell
  • Stage
  • Add a new cell
  • Save
  • Open diff view and the notebook metadata section is displayed as modified even though there are no changes.
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug notebook notebook-diff labels Oct 2, 2024
@DonJayamanne DonJayamanne self-assigned this Oct 2, 2024
@DonJayamanne DonJayamanne added this to the October 2024 milestone Oct 2, 2024
@DonJayamanne DonJayamanne mentioned this issue Oct 2, 2024
Merged
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 4, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DonJayamanne DonJayamanne

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook notebook-diff verified Verification succeeded
Projects
None yet
Milestone
October 2024
Development

Successfully merging a pull request may close this issue.

Ignore transient keys in notebook metadata when diffing of nb metadata microsoft/vscode
2 participants
@DonJayamanne @rzhao271