Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[themes] Text selection color (find, search, etc) #25966

Closed
cleidigh opened this issue May 5, 2017 · 1 comment · Fixed by #26093
Closed

[themes] Text selection color (find, search, etc) #25966

cleidigh opened this issue May 5, 2017 · 1 comment · Fixed by #26093
Assignees
@bpasero @Tyriar @aeschli
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2017

Comments

@cleidigh
Copy link
Contributor

cleidigh commented May 5, 2017 •
edited
Loading

All input box based widgets (find, file search, etc) need text selection foreground/background
UI colors.

Have to decide if there should be a global ::selection color or any individual ones are needed.

image
@egamma egamma added the themes Color theme issues label May 5, 2017
@aeschli aeschli added feature-request Request for new features or functionality themes Color theme issues and removed themes Color theme issues labels May 5, 2017
@aeschli aeschli added this to the Backlog milestone May 5, 2017
@aeschli aeschli changed the title UI Theme Add: Text selection color (find, search, etc) [themes] Text selection color (find, search, etc) May 5, 2017
@bpasero bpasero modified the milestones: May 2017, Backlog May 5, 2017
Tyriar added a commit that referenced this issue May 5, 2017
@Tyriar
Add theme key for selection
a4a4ad4 
Fixes #25966
@Tyriar Tyriar mentioned this issue May 5, 2017
Merged
@Tyriar Tyriar self-assigned this May 5, 2017
bpasero pushed a commit that referenced this issue May 8, 2017
@Tyriar @bpasero
Add theme key for selection (#26093)
971798b 
* Add theme key for selection

Fixes #25966

* 💄
@bpasero
Copy link
Member

bpasero commented May 8, 2017

Added via selection.background for May.

This was referenced May 15, 2017
Closed
Closed
@ajitid ajitid mentioned this issue May 24, 2017
Closed
4 tasks
@Tyriar Tyriar added the verification-needed Verification of issue is requested label May 26, 2017
@sandy081 sandy081 added the verified Verification succeeded label May 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@Tyriar Tyriar

@aeschli aeschli

Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2017
Development

Successfully merging a pull request may close this issue.

Add theme key for selection microsoft/vscode
6 participants
@egamma @bpasero @Tyriar @aeschli @sandy081 @cleidigh