Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No file events for root folders #29590

Closed
joaomoreno opened this issue Jun 27, 2017 · 10 comments
Closed

No file events for root folders #29590

joaomoreno opened this issue Jun 27, 2017 · 10 comments
Assignees
@bpasero
Labels
file-watcher File watcher upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone
September 2021

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jun 27, 2017 •
edited
Loading

  1. Add another folder to your workspace
  2. Delete it from disk
  • Nothing really happens
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Jun 27, 2017
@isidorn isidorn added this to the July 2017 milestone Jun 27, 2017
@isidorn isidorn modified the milestones: July 2017, August 2017 Aug 2, 2017
@isidorn
Copy link
Contributor

isidorn commented Aug 31, 2017

For this we would need to file watch roots, something which we do not do atm -> september
A related issue is #29738

@isidorn isidorn modified the milestones: September 2017, August 2017 Aug 31, 2017
@isidorn isidorn modified the milestones: September 2017, October 2017 Sep 27, 2017
@isidorn
Copy link
Contributor

isidorn commented Oct 11, 2017

@Tyriar currently the file wathcer unexpectdly shuts down when a root folder gets deleted undearneath. Is it possible for the file watcher to crash more gracefully such that the explorer can react on this and refresh?

fyi @bpasero

screen shot 2017-10-11 at 16 27 26

@isidorn
Copy link
Contributor

isidorn commented Oct 27, 2017

@Tyriar should I postpone this for November?

@Tyriar
Copy link
Member

Tyriar commented Oct 28, 2017

@isidorn I won't have time to look at this in October (too soon) or November (taking a few weeks off). If you want to look into it in the meantime, see the files in src/vs/workbench/services/files/node/watcher/nsfw/

@isidorn
Copy link
Contributor

isidorn commented Oct 30, 2017

@Tyriar thanks for the update. This is not urgent -> pushing to On-Deck milestone.

@isidorn isidorn modified the milestones: October 2017, On Deck Oct 30, 2017
@isidorn isidorn mentioned this issue Mar 5, 2018
Closed
@isidorn isidorn changed the title Multi-root: Need to handle folder deletion No file events for root folders Mar 5, 2018
@Tyriar Tyriar modified the milestones: On Deck, Backlog Sep 12, 2018
@isidorn
Copy link
Contributor

isidorn commented Sep 20, 2018

@Tyriar do we want to look into this now maybe?

@Tyriar
Copy link
Member

Tyriar commented Sep 21, 2018

The service shutdown message is coming from nsfw.

screen shot 2018-09-21 at 9 31 59 am

https://github.com/Axosoft/nsfw/blob/277aeff125166b875fdb45b1156efcdbd1456583/src/osx/FSEventsService.cpp#L85

@Tyriar Tyriar mentioned this issue Sep 21, 2018
Open
@Tyriar
Copy link
Member

Tyriar commented Sep 21, 2018

Upstream: Axosoft/nsfw#56

@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Sep 21, 2018
@isidorn
Copy link
Contributor

isidorn commented Sep 24, 2018

@Tyriar thanks for investigating

@isidorn isidorn added file-watcher File watcher and removed file-explorer Explorer widget issues labels Sep 24, 2018
@isidorn isidorn removed their assignment Sep 24, 2018
@Tyriar Tyriar added upstream-issue-linked This is an upstream issue that has been reported upstream and removed bug Issue identified by VS Code Team member as probable bug labels Oct 10, 2019
@bpasero bpasero assigned bpasero and unassigned Tyriar Sep 23, 2021
@bpasero bpasero modified the milestones: Backlog, September 2021 Sep 23, 2021
@bpasero
Copy link
Member

bpasero commented Sep 23, 2021

24b3b58 implements support for this at least when the folder is deleted directly. Detecting the delete all the way up to the root of the disk is not implemented.

@bpasero bpasero closed this as completed Sep 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
file-watcher File watcher upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
September 2021
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @isidorn @Tyriar