Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: Cannot read property 'document' of undefined #5022

Closed
aeschli opened this issue Apr 6, 2016 · 2 comments
Closed

TypeError: Cannot read property 'document' of undefined #5022

aeschli opened this issue Apr 6, 2016 · 2 comments
Assignees
@jrieken
Labels
error-telemetry VS Code - Issues generated by telemetry verified Verification succeeded
Milestone
April 2016

Comments

@aeschli
Copy link
Contributor

aeschli commented Apr 6, 2016

Our error telemetry reports now also reports issues for extension.
The 'Cannot read property 'document' of undefined' occurs for may different plugins, e.g.

Wondering if these are related and if we should do something about it (maybe better document it)
@aeschli aeschli mentioned this issue Apr 6, 2016
Closed
@jrieken jrieken added this to the April 2016 milestone Apr 6, 2016
@jrieken jrieken added the error-telemetry VS Code - Issues generated by telemetry label Apr 6, 2016
@jrieken
Copy link
Member

jrieken commented Apr 6, 2016

For some it seems like activeTextEditor isn't understood be undefined in cases. Also, I know we make it undefined when changing

jrieken added a commit that referenced this issue Apr 6, 2016
@jrieken
improve doc about activeTextEditor being undefined from time to time, #…
1373840 
…5022
jrieken added a commit that referenced this issue Apr 6, 2016
@jrieken
make sure that the falsy value for the activeTextEditor is undefined,
78dcfe1 
#5022
@jrieken
Copy link
Member

jrieken commented Apr 8, 2016

Made the doc more clear, made the falsy value undefined in all cases

@jrieken jrieken closed this as completed Apr 8, 2016
@jrieken jrieken added the verified Verification succeeded label Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
error-telemetry VS Code - Issues generated by telemetry verified Verification succeeded
Projects
None yet
Milestone
April 2016
Development

No branches or pull requests
2 participants
@jrieken @aeschli