Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't inform vscode of new function breakpoints #59746

Closed
davidcummingsaapl opened this issue Oct 1, 2018 · 2 comments
Closed

Can't inform vscode of new function breakpoints #59746

davidcummingsaapl opened this issue Oct 1, 2018 · 2 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues

Comments

@davidcummingsaapl
Copy link

  • VSCode Version: 1.28.0-insider (29e6dce)
  • OS Version: macOS

The debug protocol provided by vscode allows the IDE to inform the debug server of function breakpoints that should be set by sending a SetFunctionBreakpoints request. This request contains an array of objects of type FunctionBreakpoint.

The debug protocol also allows the debug server to inform the IDE that breakpoints have been set by sending a BreakpointEvent. This event contains information on whether the breakpoint was added, removed or changed and contains an object of type Breakpoint representing the event.

Unfortunately this Breakpoint type is for source breakpoints and doesn't contain the ability to specify information about function breakpoints. I tried a few different things by not setting line numbers, source file etc. but they all resulted in issues with the breakpoints view in vscode.

I had a look through debugSession.ts in the vscode source (see line 365) and there is some logic for function breakpoints, but it doesn't apply if the reason on the event is 'new'

@vscodebot vscodebot bot added the insiders label Oct 1, 2018
@RMacfarlane RMacfarlane added the debug Debug viewlet, configurations, breakpoints, adapter issues label Oct 1, 2018
@weinand
Copy link
Contributor

weinand commented Oct 1, 2018

@davidcummingsaapl please file this request against the DAP since this feature requires a protocol change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

3 participants