Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded item in debug console collapses when new output is added #64460

Closed
roblourens opened this issue Dec 5, 2018 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues tree-widget Tree widget issues verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

I am in a debugging session where when new output is added to the debug console, expanded objects are collapsed. This only happens in EH debugging, not node, for some reason.

Add this code to the activate method of an extension:

    setInterval(() => {
        const obj = {
            added: [],
            removed: [{
                blah: 123,
                foobar: 432
            }],
            changed: []
        };
        console.log({ a: obj, a2: 123, a3: [obj, obj] });
    }, 4000);

dec-05-2018 14-30-56

I debugged this enough to verify that nothing is calling "collapse" on the tree, it seems like it's just happening when the DataTree refreshes. https://github.com/Microsoft/vscode/blob/master/src/vs/base/browser/ui/tree/asyncDataTree.ts#L524

I can't figure out why this doesn't happen when debugging a simple node script with the same code.

@joaomoreno joaomoreno added this to the November 2018 milestone Dec 6, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues debug Debug viewlet, configurations, breakpoints, adapter issues debug-console labels Dec 6, 2018
@joaomoreno joaomoreno removed their assignment Dec 6, 2018
@isidorn
Copy link
Contributor

isidorn commented Dec 6, 2018

@roblourens nice catch. It was only happening in this case since we comput ids differently in this corner case when the output is coming from the EH

@isidorn isidorn closed this as completed in 530e1b8 Dec 6, 2018
@alexr00 alexr00 added the verified Verification succeeded label Dec 7, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants