Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Normal" filtering input for trees #70646

Closed
usernamehw opened this issue Mar 17, 2019 · 19 comments · Fixed by #152481
Closed

"Normal" filtering input for trees #70646

usernamehw opened this issue Mar 17, 2019 · 19 comments · Fixed by #152481
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan tree-widget Tree widget issues
Milestone

Comments

@usernamehw
Copy link
Contributor

usernamehw commented Mar 17, 2019

Issue Type: Feature Request

https://code.visualstudio.com/updates/v1_31#_new-tree-widget

Is it possible to replace current filtering feature with an ordinary input element?

normal input filter on type
✅ standard element
✅ being able to have simple navigation and still filter items
✅ no clash with extension contributed keybindings ✅❌ can be mitigated with workbench.list.automaticKeyboardNavigation & list.toggleKeyboardNavigation
✅ can paste text
✅ can undo
✅ can select text
✅ good discoverability
✅ preverve text on reload
❌ takes one row of space ✅ only visible while typing
outline_old outline_new

filter disappeared on outline view #70095
Performing a search on Outline #70640
Filter box in Outline has dissapeared in Release 1.32.3 #70605
Search field in structure side panel #70575
Search input field missing in new outline in Code 1.32.1 #70038

Yeah, you can tell those people where to find the "filter on type" feature, but all the new users potentially would never even know that it exists.

@MgSam
Copy link

MgSam commented Apr 23, 2019

To add my 2 cents- you really need to restore the search boxes. The filtering ability you guys added for trees is a nice idea but is absolutely horrible from a UX perspective. It has zero discoverability. And even once you know it exists, it still sucks because you have to give the tree focus by clicking somewhere random inside of it before typing. You can't possibly expect all your users to dig through documentation to learn how to perform a basic search.

A good rule of thumb for UX design is that if you're doing something no other application does, there's probably a reason why that is (and not because it's a great idea- people have been building GUIs for decades- there are precious few "undiscovered" UI paradigms left).

@martbean
Copy link

martbean commented May 1, 2019

I agree. Added to which, for whatever reason 'Filter on Type' doesn't seem to work for me at all. Possibly one of my extensions is interfering with it but regardless, the old search box was much more user-friendly. Can it at least be an option?

@futurekill
Copy link

+1 From me...I had to search through github tickets to find out that 1. it was removed and 2. how to access that functionality. As it is now it's completely intuitive.

@JasonZough
Copy link

desperate for a filter box in outline when writting Vue.

@nataliethistime
Copy link

+1 - VS Code's Vim seems to eat my keyboard input, rendering this feature unusable. Please bring back a text box so that this works again. ❤️

@joaomoreno joaomoreno added feature-request Request for new features or functionality tree-widget Tree widget issues *out-of-scope Posted issue is not in scope of VS Code and removed editor-find Editor find operations labels Oct 8, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 8, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 8, 2019
@AlekSi
Copy link

AlekSi commented Oct 17, 2019

I.e. has it gathered more than 10 up-votes

Yes. Please re-open.

@ghost
Copy link

ghost commented Nov 10, 2019

Looking forward this feature in the next release:)

@usernamehw
Copy link
Contributor Author

The issue is closed not because it was fixed. It won't happen in the next release.

@ghost
Copy link

ghost commented Nov 10, 2019

Hi Alex,
How you said "It won't happen in the next release." but not fixed yet. Does it mean the input box for outline view will come back in VS Code 1.40.1?

I think many people are waiting for the return back of this feature.

@joaomoreno joaomoreno removed the *out-of-scope Posted issue is not in scope of VS Code label Nov 13, 2019
@joaomoreno joaomoreno reopened this Nov 13, 2019
@kh
Copy link

kh commented Nov 28, 2019

This is a must for me, filter on type feels so clumsy, the behaviour is unpredictable as you have to guess when you have the focus (sometimes you don't and you're editing the file instead of searching), you can't edit a character in the middle if you mistyped.

Along with #66971 this issue would bring a big boost in productivity.

@salgiza
Copy link

salgiza commented Feb 4, 2022

I wonder how many people read the release notes for v1.64, which includes an animation on how to move the outline to the new side panel, did it, though "oooh, cool this might be useful" followed by a "wait, how the hell do I search for a method in this panel?" (and that's the story of how I got here).

@bytehow
Copy link

bytehow commented Jun 2, 2022

This "filter on type" is so cumbersome, especially when using the Vim extension. I have to click on the "Outline" section header to give it focus but not move my cursor. I have to click it again because if it the panel was already open, the previous click collapses the panel. Now outline has focus, but I've got to 1) make sure Outline still has focus and 2) type / so I can enter Vim's search mode before I can start filtering.

PLEASE at least make the filtering input box an option!

@hntrewhitt
Copy link

It would be very useful to be able to search/filter the entire File Explorer tree (or the tree within a specific folder) based on filename/extension; being able to type something like **/*.js or a regexp like .jsx?$ and see all the files in the whole tree (or tree within a folder) whose filename match that.

@joaomoreno joaomoreno self-assigned this Jul 15, 2022
@joaomoreno joaomoreno modified the milestones: Backlog, July 2022 Jul 15, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 18, 2022
@joaomoreno joaomoreno added on-testplan on-release-notes Issue/pull request mentioned in release notes labels Jul 24, 2022
@MohamedLamineAllal
Copy link

is this feature no more working with 1.70.2? When I type, I get taken to a. file that starts with the letter and does not activate the filtering mechanism ??

@MohamedLamineAllal
Copy link

MohamedLamineAllal commented Aug 23, 2022

I'll answer myself. There was an update. And the way it works now is by Cmd + F or Ctrl + F while focused on the tree. Way better.

https://code.visualstudio.com/updates/v1_70#_tree-find-control

Official doc wasn't updated on that regard.

@joaomoreno
Copy link
Member

Doc update PR: microsoft/vscode-docs#5588

@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan tree-widget Tree widget issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.