Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript errors are multiline but do not surface in the editor or problems view #7401

Closed
bpasero opened this issue Jun 8, 2016 · 9 comments
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code tasks Task system issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 8, 2016

I am starting to selfhost on running the gulp tsb task in the workbench. Since errors are multi line, I am missing important information I had before:

image

Neither are the multi line errors showing up in the hover in the editor nor are they showing up in the problems view.

image

Marking as important because this makes my selfhost unusable with this setup.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Jun 8, 2016
@bpasero bpasero added the error-list Problems view label Jun 8, 2016
@sandy081
Copy link
Member

sandy081 commented Jun 8, 2016

@bpasero so the markers are not having the complete information?

@bpasero
Copy link
Member Author

bpasero commented Jun 8, 2016

@sandy081 the output was showing multi line error and the marker was showing single line in hover and problems view. Not sure if this is a UI problem or marker problem.

@bpasero
Copy link
Member Author

bpasero commented Jun 8, 2016

I pushed a change to use the markers only for closed documents (d9491c0). I will report back if this improves my experience.

@sandy081 sandy081 removed their assignment Jul 5, 2016
@sandy081
Copy link
Member

sandy081 commented Jul 5, 2016

@bpasero What is the impact after your change?

@bpasero
Copy link
Member Author

bpasero commented Jul 5, 2016

Sorry, not using this anymore from within Code. Got so used to my terminal outside :-/

@dbaeumer dbaeumer added the tasks Task system issues label Jul 5, 2016
@dbaeumer
Copy link
Member

dbaeumer commented Jul 5, 2016

Actually addressing this might cause some work inside multi line problem matchers. Multi line matchers are made for a use case like

Errors in file A.ts
1,1: An error on line one
2,1: An error on line two

I will keep this as a feature request but I think we would benefit more from a project wide TS builder than addressing this use case in the problem matcher.

@dbaeumer dbaeumer added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug error-list Problems view labels Jul 5, 2016
@ncannasse
Copy link

That seems like a important fix indeed. Actually our Haxe compiler integration is having issues with long error messages being cut, and there is not much that can be done on our side, see vshaxe/vshaxe#137

@dbaeumer dbaeumer removed the important Issue identified as high-priority label Jul 13, 2017
@dbaeumer dbaeumer added this to the Backlog milestone Jul 13, 2017
@alexr00 alexr00 assigned alexr00 and unassigned dbaeumer Oct 7, 2019
@alexr00
Copy link
Member

alexr00 commented Oct 10, 2019

Would be solved by #59337. Otherwise, out of scope.

@alexr00 alexr00 added the *out-of-scope Posted issue is not in scope of VS Code label Oct 10, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 10, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code tasks Task system issues
Projects
None yet
Development

No branches or pull requests

5 participants