Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some keybingings are shown on different keyboard layout #80094

Closed
w7rus opened this issue Aug 30, 2019 · 7 comments · Fixed by microsoft/azuredatastudio#7206
Closed

Some keybingings are shown on different keyboard layout #80094

w7rus opened this issue Aug 30, 2019 · 7 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keyboard-layout Keyboard layout issues verified Verification succeeded windows VS Code on Windows issues

Comments

@w7rus
Copy link

w7rus commented Aug 30, 2019

Issue Type: Bug

Having a US Windows 10 system. Additionally install russian language pack.
Some keybindings in tutorial and interface overview using russian letters instead of english ones.
Examples:
https://i.imgur.com/Ludg8Jh.jpg
https://i.imgur.com/RPBnKNE.jpg

VS Code version: Code 1.37.1 (f06011a, 2019-08-15T16:17:55.855Z)
OS version: Windows_NT x64 10.0.17763

System Info
Item Value
CPUs Intel(R) Core(TM) i5-7300HQ CPU @ 2.50GHz (4 x 2496)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: disabled_off
protected_video_decode: enabled
rasterization: enabled
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.89GB (6.38GB free)
Process Argv
Screen Reader no
VM 50%
Extensions (3)
Extension Author (truncated) Version
beautify Hoo 1.5.0
Lua key 0.0.9
vscode-icons vsc 9.3.0
@techiedesu
Copy link

Same.
image

@alexdima alexdima added the windows VS Code on Windows issues label Sep 7, 2019
@alexdima
Copy link
Member

alexdima commented Sep 7, 2019

I could not reproduce. I have installed the following:
image

And I chose it in the input language picker:
image

And here is how that welcome page looks for me:
image

@alexdima alexdima added info-needed Issue requires more information from poster keyboard-layout Keyboard layout issues labels Sep 7, 2019
@techiedesu
Copy link

techiedesu commented Sep 8, 2019

@alexandrudima I tried to find steps to reproduce:

  1. Open VSCode
  2. Change keyboard language to russian
  3. Click "Interface Overview"

If you forgot to change language (keyboard, not system) -- restart VSCode.

@alexdima
Copy link
Member

I could reproduce now, I'm not sure what was different, I might have had keybindings customizations by accident when I last tried.

image

But this does not look like a bug to me:

When I use the on screen keyboard, it appears that the key left of 1 is labeled with ё and when I press Ctrl + ё I get the integrated terminal. So the keybinding is displayed correctly in the welcome guide, pressing Ctrl + ё toggles the integrated terminal:

russian

@techiedesu
Copy link

We cannot understand why other hotkeys use latin letters. It is not consistent.

@alexdima
Copy link
Member

That is a good point. We have special case code for all the keys A - Z here but that only covers A-Z...

@alexdima
Copy link
Member

I will tweak this, but just to clarify, my change will impact more than the label for Backquote under the Russian keyboard layout:

BracketLeft   х -> [
BracketRight  ъ -> ]
Semicolon     ж -> ;
Quote         э -> '
Backquote     ё -> `
Comma         б -> ,
Period        ю -> .
Slash         . -> /

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Sep 11, 2019
@alexdima alexdima added this to the September 2019 milestone Sep 11, 2019
@roblourens roblourens added the verified Verification succeeded label Oct 3, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug keyboard-layout Keyboard layout issues verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants