Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nonintuitive iconage in call heiarchy #86125

Closed
JacksonKearl opened this issue Dec 3, 2019 · 9 comments
Closed

nonintuitive iconage in call heiarchy #86125

JacksonKearl opened this issue Dec 3, 2019 · 9 comments
Assignees
Labels
callhierarchy polish Cleanup and polish issue
Milestone

Comments

@JacksonKearl
Copy link
Contributor

testing #85924

image

The "refresh" icon on the tree items makes me think it will reload the results of that node, especially as we use the icon to do the same in the top acton bar. I think using the "Show incoming/outgoing calls" icon would make more sense.

@jrieken
Copy link
Member

jrieken commented Dec 3, 2019

@misolori Do you have a suggestion? I was considering the "phone handle icon" that we use to toggle the call hierarchy direction.

@jrieken jrieken added the polish Cleanup and polish issue label Dec 3, 2019
@miguelsolorio
Copy link
Contributor

@jrieken using the same icon makes sense here. Related: the current phone handle icon looks out of place with the old style, I can re-create it to match our new style.

@jrieken
Copy link
Member

jrieken commented Dec 4, 2019

Yes, please a new icon. I took it from the VS set but something more modern is very much appreciated.

@jrieken
Copy link
Member

jrieken commented Dec 4, 2019

Catch 22 - the icon atop always shows the other direction, e.g when in "caller of"-mode the icon shows the "call from"-mode to switch to that mode but the inline command should be always be the current mode. that means the icons are always different... Not sure what to do? Should the toggle atop reflect the current mode instead?

Screenshot 2019-12-04 at 11 15 40

jrieken added a commit to microsoft/vscode-references-view that referenced this issue Dec 4, 2019
@jrieken jrieken closed this as completed Dec 4, 2019
@jrieken jrieken reopened this Dec 4, 2019
@JacksonKearl
Copy link
Contributor Author

I think the difference is subtle enough that it users will understand the connection and it wont be particularly jarring. @misolori?

@miguelsolorio
Copy link
Contributor

I think our advanced users will pickup on the subtlety but the average might not. I still think it works better than the refresh icon.

@eamodio
Copy link
Contributor

eamodio commented Dec 4, 2019

Related to this -- I expected to be able to right-click on an item in the hierarchy view and get to the Show Call Hierarchy action

@miguelsolorio
Copy link
Contributor

Icon design being handled by #86305

jrieken added a commit to microsoft/vscode-references-view that referenced this issue Dec 5, 2019
jrieken added a commit that referenced this issue Dec 5, 2019
@jrieken
Copy link
Member

jrieken commented Dec 5, 2019

Screenshot 2019-12-05 at 10 48 15

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
callhierarchy polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

4 participants