-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nonintuitive iconage in call heiarchy #86125
Comments
@misolori Do you have a suggestion? I was considering the "phone handle icon" that we use to toggle the call hierarchy direction. |
@jrieken using the same icon makes sense here. Related: the current phone handle icon looks out of place with the old style, I can re-create it to match our new style. |
Yes, please a new icon. I took it from the VS set but something more modern is very much appreciated. |
Catch 22 - the icon atop always shows the other direction, e.g when in "caller of"-mode the icon shows the "call from"-mode to switch to that mode but the inline command should be always be the current mode. that means the icons are always different... Not sure what to do? Should the toggle atop reflect the current mode instead? |
I think the difference is subtle enough that it users will understand the connection and it wont be particularly jarring. @misolori? |
I think our advanced users will pickup on the subtlety but the average might not. I still think it works better than the refresh icon. |
Related to this -- I expected to be able to right-click on an item in the hierarchy view and get to the Show Call Hierarchy action |
Icon design being handled by #86305 |
testing #85924
The "refresh" icon on the tree items makes me think it will reload the results of that node, especially as we use the icon to do the same in the top acton bar. I think using the "Show incoming/outgoing calls" icon would make more sense.
The text was updated successfully, but these errors were encountered: