"Find All References" unnecessarily requires a word position

[matklad]

If I invoke "find refrences" when the cursor is on a puncuation character, the editor seems to bypass the server and says "no results" without making any requests:

However, there are valid cases to invoke "find usages" on a punctuation character:

• in languages with operator overloading, searching for usages of + is a pretty natural thing to do
• In Kotlin, searching for ( in data class Point(val x, val y) will search for constructor calls (this is the feature we are trying to mimic in rust-analyzer)

I've tested and in Emacs I can ref-search punctuation. It's interesting that goto definition does not try to check if thing at point is an identifier.

[dbaeumer]

Moving to VS Code since the LSP client library doesn't receive the call in the first place.

[jrieken]

Yeah, for peek this works but the viewlet is more strict because it wants to add a history entry like "foo - some/file.ts - references" and without a word this gets tricky... Tho, in that case we should just use the character at the position

[matklad]

Confirmed that peek references indeed work with rust-analyzer's implementation!

[jzyrobert]

It looks like you'd have to implement a custom check or think of a regex to pass to getWordRangeAtPosition, about here

Should it allow any non whitespace character if its not a valid word?