Command+Enter to commit does not work anymore

[daimor]

• VSCode Version:
  Version: 1.42.0-insider
  Commit: be0aca7
  Date: 2020-01-31T13:51:59.883Z
  Electron: 6.1.6
  Chrome: 76.0.3809.146
  Node.js: 12.4.0
  V8: 7.6.303.31-electron.0
  OS: Darwin x64 19.2.0
• OS Version: macOS Catalina 10.15.2

Steps to Reproduce:

1. put some SCM commit message
2. Press ⌘Enter, and nothing happens

Does this issue occur when all extensions are disabled?: Yes

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Auto Importing stopped working with November's update (#87304)
• Mouse back and forward buttons do not work on Mac OS anymore (#88029)

[gjsjohnmurray]

Maybe caused by #84831

cc @joaomoreno

[joaomoreno]

Interesting, I can't repro here. Do you have Cmd Enter configured to more commands in your keybindings? Run Preferences: Open Keyboard Shortcuts and search for Cmd Enter

[daimor]

Yep, found it. I have a custom keybinding for trigger suggest.

But I think it should not trigger there. So, it should work anyway.

[daimor]

And it works after reset

[joaomoreno]

👍 Got it, you can add && !editorSimpleInput to that when condition.

[daimor]

@joaomoreno thanks, would it be possible to add it default keybindings as well?
So, next time, it would be possible to just change key without changing when.

[joaomoreno]

Actually, the suggest widget will come to simple editor inputs as well, albeit as Ctrl Enter, so we can't change the default when clause.