Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug adapter 'continued' event not working #9149

Closed
roblourens opened this issue Jul 12, 2016 · 2 comments
Closed

Debug adapter 'continued' event not working #9149

roblourens opened this issue Jul 12, 2016 · 2 comments
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone
July 2016

Comments

@roblourens
Copy link
Member

vscode-chrome-debug is firing the private 'continued' event to support the continued button that shows up on the Chrome window, but it seems like that's not working anymore. Is there still some way to implement this?

Microsoft/vscode-chrome-debug#201
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 12, 2016
@weinand weinand added this to the July 2016 milestone Jul 13, 2016
@isidorn
Copy link
Contributor

isidorn commented Jul 19, 2016

No, this was an internal event which we used as a workaround. Since we fixed #5966 we have removed that event.
If we want to add this we should first surface it in the protocol, thus assigning to @weinand

@isidorn isidorn removed their assignment Jul 19, 2016
@weinand weinand mentioned this issue Jul 19, 2016
Closed
@weinand
Copy link
Contributor

weinand commented Jul 19, 2016

@isidorn I've added a ContinuedEvent to the protocol.

@weinand weinand assigned isidorn and unassigned weinand Jul 19, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Milestone
July 2016
Development

No branches or pull requests
3 participants
@roblourens @weinand @isidorn