Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More stable history in references viewlet #92073

Closed
jrieken opened this issue Mar 5, 2020 · 2 comments
Closed

More stable history in references viewlet #92073

jrieken opened this issue Mar 5, 2020 · 2 comments
Assignees
@jrieken
Labels
feature-request Request for new features or functionality references-viewlet verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2020

Comments

@jrieken
Copy link
Member

jrieken commented Mar 5, 2020

Currently, history entries in the references viewlet are not dynamic. That often leads to a non working or bogous behaviour, e.g the lines have moves and reference search is now run on a different symbol or not at all anymore. This is to add some additional word-refinding-logic so that history is somewhat dynamic.
@jrieken jrieken self-assigned this Mar 5, 2020
@jrieken jrieken added this to the March 2020 milestone Mar 5, 2020
@jrieken jrieken added feature-request Request for new features or functionality references-viewlet labels Mar 5, 2020
jrieken added a commit to microsoft/vscode-references-view that referenced this issue Mar 5, 2020
@jrieken
add word anchor to history items, microsoft/vscode#92073
72f7d3e
@jrieken jrieken closed this as completed Mar 5, 2020
jrieken added a commit that referenced this issue Mar 5, 2020
@jrieken
update extension dependency, #92073
0bec5a3
@jrieken jrieken added the verification-needed Verification of issue is requested label Mar 5, 2020
@connor4312 connor4312 added the verified Verification succeeded label Apr 1, 2020
@connor4312
Copy link
Member

@jrieken can you add verification steps?

@connor4312 connor4312 added verification-steps-needed Steps to verify are needed for verification and removed verified Verification succeeded labels Apr 1, 2020
@jrieken
Copy link
Member Author

jrieken commented Apr 2, 2020

To verify:

  • Search for symbol foo
  • clear results
  • in the same add or remove lines above symbol foo
  • re-run search from history and make sure it still searches for foo

@jrieken jrieken removed the verification-steps-needed Steps to verify are needed for verification label Apr 2, 2020
@sandy081 sandy081 added the verified Verification succeeded label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality references-viewlet verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@jrieken @connor4312 @sandy081