You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the comments API allows comments to include links to HTTP-based resources, but it would be great if they could also include references to VS Code commands (using the [](command:commandName) syntax). As part of building out the CodeTour extension, I'd like to be able to have tour steps include links to automate workbench actions such as starting the debugger/etc. (as opposed to telling the user to do it), which would help create a more interactive/guided experience.
To ensure this experience is secure/predictable, maybe the CommentController could introduce a new setting that determines whether command links are enabled or not? The WebViewOptions type already include a enableCommandUris setting, and so maybe we could add the equivalent to the CommentController? That way, the GitHub PR extension doesn't need to support them/etc. if it doesn't make sense.
Hey @lostintangent , I just realized this is already supported as we allow using MarkdownString for Comment.body, all you need to do in the extension is when you create a Comment object, make sure that isTrusted is set on vscode.MarkdownString.
Currently, the comments API allows comments to include links to HTTP-based resources, but it would be great if they could also include references to VS Code commands (using the
[](command:commandName)
syntax). As part of building out the CodeTour extension, I'd like to be able to have tour steps include links to automate workbench actions such as starting the debugger/etc. (as opposed to telling the user to do it), which would help create a more interactive/guided experience.To ensure this experience is secure/predictable, maybe the
CommentController
could introduce a new setting that determines whether command links are enabled or not? TheWebViewOptions
type already include aenableCommandUris
setting, and so maybe we could add the equivalent to theCommentController
? That way, the GitHub PR extension doesn't need to support them/etc. if it doesn't make sense.// CC @rebornix
The text was updated successfully, but these errors were encountered: