Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Terminal: Copy Selection' no way to be executed from the command palette #9761

Closed
isidorn opened this issue Jul 26, 2016 · 3 comments
Closed

'Terminal: Copy Selection' no way to be executed from the command palette #9761

isidorn opened this issue Jul 26, 2016 · 3 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality on-testplan terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
June 2017

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 26, 2016

Refs: #9100

Linux, insiders

  1. Try to execute the command 'Terminal: Copy Selection' from the command palette
  2. There is no way to do this, since when the command palette has focus the terminal does not and the action will complain
  3. I would expect the action to still work, or to not be present in the command palette

This action and the paste into intregrated terminal do not feel like global workbench actions to me. Due to this and #9760 I propose to remove them from the command pallete. If there is no mechanism for global workbench actions to be omitted from the command pallete we should introduce one, since these actions should not be in the command pallete imho
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Jul 26, 2016
@Tyriar
Copy link
Member

Tyriar commented Jul 26, 2016 •
edited
Loading

This is a known issue, it can be made to work once virtual selection is added to xterm.js xtermjs/xterm.js#207

@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jul 26, 2016
@Tyriar Tyriar added this to the Backlog milestone Jul 26, 2016
@Tyriar Tyriar mentioned this issue Apr 18, 2017
Closed
@Tyriar
Copy link
Member

Tyriar commented Apr 20, 2017

This will be fixed when we manage the selection model ourselves #9958

@Tyriar Tyriar closed this as completed Apr 20, 2017
@Tyriar Tyriar added *duplicate Issue identified as a duplicate of another issue(s) and removed bug Issue identified by VS Code Team member as probable bug labels Apr 20, 2017
@Tyriar Tyriar mentioned this issue Apr 20, 2017
Closed
@Tyriar Tyriar mentioned this issue May 21, 2017
Merged
64 tasks
@Tyriar Tyriar added feature-request Request for new features or functionality and removed *duplicate Issue identified as a duplicate of another issue(s) labels Jun 9, 2017
@Tyriar Tyriar modified the milestones: June 2017, Backlog Jun 9, 2017
@Tyriar
Copy link
Member

Tyriar commented Jun 9, 2017 •
edited
Loading

Fixed in #9958, xtermjs/xterm.js#670

@Tyriar Tyriar mentioned this issue Jun 26, 2017
Closed
3 tasks
@Tyriar Tyriar mentioned this issue Jul 10, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality on-testplan terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
3 participants
@roblourens @isidorn @Tyriar