Completion adds more duplicate snippets as you type

[jdneo]

Version: 1.46.0-insider (user setup)
Commit: 288852d
Date: 2020-05-12T05:43:31.363Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363
Steps to Reproduce:

Completion adds more duplicate snippets as you type

We have predefined some snippets in a json file and registered them in package.json. Meanwhile, the language server side will also contribute some other snippets.

This issue only happens in 1.46 insider version, in the stable version (1.45.0), it works fine. So I guess it's a regression in the insider?

Also, if I just start the client side (not launch the language server), the duplication won't be observed. Does that mean something wrong when merging the results from client & server when providing the completion list?

[jrieken]

Meanwhile, the language server side will also contribute some other snippets.

I can repro for Java but not for TypeScript... How does the language service contribute these other snippets? Does it tweak the snippet file on disk?

[jdneo]

The language server will resolve some other snippets according to the context. It won't tweak the snippet json file.

And the snippets defined in the json file are different from the language server side, which means they have no intersection

[jrieken]

Ok - this only happens when using incomplete results list and is due to bogous provider filtering, e.g the snippet provider is asked again for suggestion despite its suggestion being kept...

[jdneo]

@jrieken Thank you, I'll test it after new insider released and let you know if the problem fixed.

[jdneo]

@jrieken Verified the issue has been fixed. Thank you!

[github-actions]

This bug has been fixed in to the latest release of VS Code Insiders!

@jdneo, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version e1d8f51 of Insiders (today's or later - you can use Help: About in the command pallette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!