Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace performance util with native one #99597

Closed
jrieken opened this issue Jun 8, 2020 · 0 comments
Closed

Replace performance util with native one #99597

jrieken opened this issue Jun 8, 2020 · 0 comments
Assignees
@jrieken
Labels
debt Code quality issues
Milestone
June 2020

Comments

@jrieken
Copy link
Member

jrieken commented Jun 8, 2020

We have src/vs/base/common/performance.js which is from a time when we couldn't use performance in browser context yet. In browser-context we should use performance, in node context we should use perf_hooks
@jrieken jrieken self-assigned this Jun 8, 2020
@jrieken jrieken added this to the June 2020 milestone Jun 8, 2020
@jrieken jrieken added the debt Code quality issues label Jun 8, 2020
jrieken added a commit that referenced this issue Jun 8, 2020
@jrieken
clean-up for #99597
04d78b2
jrieken added a commit that referenced this issue Jun 8, 2020
@jrieken
write directly to _performanceEntries instead of importing performanc…
3a56d1d 
…e-object, #99597
@jrieken jrieken closed this as completed Jun 8, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
debt Code quality issues
Projects
None yet
Milestone
June 2020
Development

No branches or pull requests
1 participant
@jrieken