Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension APIs: suggest window is displayed despite not having any suggestions #997

Closed
jpoon opened this issue Dec 4, 2015 · 3 comments
Closed
Labels
feature-request Request for new features or functionality VIM VIM issue
Milestone

Comments

@jpoon
Copy link

jpoon commented Dec 4, 2015

Context

For the VIM extension, we need to add a keybinding for every key input, do some stuff, then manually insert it into the active text editor. Despite inserting a character at the current position, it will hide the suggest/autocomplete window.

Problem

As you type and press a key that triggers an suggest window (e.g. .), regardless of the next character inserted via the active text editor API, it will close the suggest window.

We can manually trigger the suggest window following every insert via

vscode.commands.executeCommand("editor.action.triggerSuggest");

But this results in the suggest window showing up even if there is nothing to suggest. Is there a way to trigger the suggest window only if there are actually suggestions?

@egamma egamma added the feature-request Request for new features or functionality label Dec 4, 2015
@egamma egamma modified the milestone: Backlog Dec 10, 2015
@egamma egamma added the VIM VIM issue label Jan 8, 2016
@ghost
Copy link

ghost commented Feb 11, 2016

Update: vscode now has an editor.cursorStyle setting that allows a block value. The issue as written is still valid, since (AFAICS) there's no way to control it from the extensions API.

@ghost
Copy link

ghost commented Feb 11, 2016

Sorry, that comment was supposed to be aimed at issue #561.

@alexdima alexdima modified the milestones: March 2016, Backlog Mar 12, 2016
@alexdima
Copy link
Member

@jpoon Please see https://github.com/alexandrudima/vscode-vim if you are authoring a vim emulation extension for VS Code. It delegates typing back to the VS Code editor when in insertion mode.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality VIM VIM issue
Projects
None yet
Development

No branches or pull requests

3 participants