Add ligature support to terminal #120452
Closed
Add ligature support to terminal #120452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't disable without reload right now due to xtermjs/xterm.js#3289
deepak1556
reviewed
Apr 5, 2021
| 'force-color-profile', | ||
|
|
||
| // Enable experimental font access for terminal ligatures | ||
| `enable-features='FontAccess'` |
There was a problem hiding this comment.
Did this work ? I would expect appendSwitch to ignore this, it should instead be
app.commandLine.appendSwitch('enable-features', 'FontAccess');
There was a problem hiding this comment.
Yep it worked, can change it though
There was a problem hiding this comment.
lets keep it separate for consistency.
|
Closing in favor of #139537 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #34103
@deepak1556 see main/app
Todo: