Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OnPaste Indenting after JavaDoc #128812

Closed
wants to merge 1 commit into from
Closed

Conversation

ssigwart
Copy link
Contributor

This PR fixes #119225. It prevents an extra space from being inserted after JavaDoc style comments.

To test, you can paste something like this.

/**
 * Function
 */
public func1(): number
{
	return 1;
}

I was trying to add an automated test to cursor.test.ts or indentation.test.ts, but wasn't able to figure it out. Any tips on how to do that?

Copy link

@alexghirelli alexghirelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ssigwart
Copy link
Contributor Author

@alexghirelli, I'm not allowed to merge branches. Will someone else merge this?

@alexghirelli
Copy link

alexghirelli commented Jul 27, 2021

I think @rebornix can help you.

@ssigwart
Copy link
Contributor Author

Ok. Thank you.

@adamreisnz
Copy link

@rebornix @alexghirelli any chance this could get merged?

This is a really frustrating bug that causes us to have to manually remove the single space each time we copy paste a function or class declaration with a block comment.

@ssigwart
Copy link
Contributor Author

ssigwart commented Nov 6, 2021

I'm closing this. I found a better solution that I implemented in #136579.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pasting into code line below a jsdoc block comment auto-indents by one space character
4 participants