Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Light High Contrast theme #143398

Merged
merged 6 commits into from
Feb 18, 2022
Merged

Add Light High Contrast theme #143398

merged 6 commits into from
Feb 18, 2022

Conversation

daviddossett
Copy link
Contributor

@daviddossett daviddossett commented Feb 18, 2022

This PR fixes #141652 by adding a light high contrast theme to the default theme options. This change also splits the high contrast theme options to "Default High Contrast" and "Light High Contrast (Beta)" in the quick pick.

It does not extend any "default" high contrast theme behaviors to differentiate between light and dark.

CleanShot 2022-02-18 at 12 09 22@2x

@daviddossett daviddossett merged commit 4da6b54 into main Feb 18, 2022
@daviddossett daviddossett deleted the ddossett/light-hc-theme branch February 18, 2022 22:41
@isidorn
Copy link
Contributor

isidorn commented Feb 21, 2022

Great work, now we just need to test this extensively and fine tune the colors. Thanks!

@daviddossett daviddossett added the verification-needed Verification of issue is requested label Feb 21, 2022
@daviddossett daviddossett removed the verification-needed Verification of issue is requested label Mar 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce high contrast light theme
2 participants