Fix branch checkout after git clone #160922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lszomoru
reviewed
Sep 15, 2022
lszomoru
approved these changes
Sep 15, 2022
benibenj
pushed a commit
that referenced
this pull request
Sep 15, 2022
* Fix branch checkout after git clone * Add progress notification while checking out ref * Remove promise chain
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #158386
The previous implementation would always fail to discover the repository we were interested in, because
getRepositoryonly looks at repositories that are already known to the git extension, and the newly cloned git repo needs to be explicitly opened withopenRepositoryfirst.