Add max height to hover #164093
Merged
Add max height to hover #164093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
commented
Oct 21, 2022
| } | ||
|
|
||
| // Make sure not to accidentally enlarge the hover when setting a maxHeight for it | ||
| maxHeight = Math.min(maxHeight, this._hover.containerDomNode.clientHeight); |
There was a problem hiding this comment.
I'm thinking this might be redundant, but it was a worry expressed in #163879 (comment)
alexr00
approved these changes
Oct 21, 2022
Hashimlokasher
approved these changes
Oct 21, 2022
formigoni
pushed a commit
to formigoni/vscode
that referenced
this pull request
Oct 27, 2022
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #159088
Fixes #158921
This PR splits off and improves part of #163879