Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css/json/html] move to l10n #165725

Merged
merged 3 commits into from
Nov 8, 2022
Merged

[css/json/html] move to l10n #165725

merged 3 commits into from
Nov 8, 2022

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Nov 7, 2022

For #164438

@aeschli aeschli self-assigned this Nov 7, 2022
@aeschli aeschli enabled auto-merge (squash) November 7, 2022 17:07
@aeschli aeschli added this to the November 2022 milestone Nov 7, 2022
TylerLeonhardt
TylerLeonhardt previously approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I saw a couple of strings that weren't localized:

https://insiders.vscode.dev/github/microsoft/vscode/blob/bd5787cb5f263c96276ce054a37e1ce83c463e46/extensions/css-language-features/client/src/cssClient.ts#L154

https://insiders.vscode.dev/github/microsoft/vscode/blob/bd5787cb5f263c96276ce054a37e1ce83c463e46/extensions/css-language-features/client/src/cssClient.ts#L162

So it might be worth looking for the show*Message API instances and making sure they're all covered.

@aeschli aeschli merged commit afac952 into main Nov 8, 2022
@aeschli aeschli deleted the aeschli/164438 branch November 8, 2022 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
November 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@aeschli @TylerLeonhardt