Revert "Fix tree data provider being accessed after disposed"

[sandy081]

Reverts #165087
Fixes #165739

@alexr00 Reverting this fix because it breaks other tree views - settings sync views are no longer showing data

[joyceerhl]

This fixes #165739

[alexr00]

I haven't yet been able to come up with another solution that doesn't break the tree. We can revert for now. @joyceerhl and @sandy081 can your trees set the data provider earlier instead of waiting for set visible?

[alexr00]

Actually, I don't see why they couldn't. The tree view constructor is very light after the perf improvements I did last month.

vscode/src/vs/workbench/browser/parts/views/treeView.ts

Lines 246 to 267 in cf46b99

	constructor(
	readonly id: string,
	private _title: string,
	@IThemeService private readonly themeService: IThemeService,
	@IInstantiationService private readonly instantiationService: IInstantiationService,
	@ICommandService private readonly commandService: ICommandService,
	@IConfigurationService private readonly configurationService: IConfigurationService,
	@IProgressService protected readonly progressService: IProgressService,
	@IContextMenuService private readonly contextMenuService: IContextMenuService,
	@IKeybindingService private readonly keybindingService: IKeybindingService,
	@INotificationService private readonly notificationService: INotificationService,
	@IViewDescriptorService private readonly viewDescriptorService: IViewDescriptorService,
	@IHoverService private readonly hoverService: IHoverService,
	@IContextKeyService private readonly contextKeyService: IContextKeyService,
	@IActivityService private readonly activityService: IActivityService,
	@ILogService private readonly logService: ILogService
	) {
	super();
	this.root = new Root();
	// Try not to add anything that could be costly to this constructor. It gets called once per tree view
	// during startup, and anything added here can affect performance.
	}

[alexr00]

New PR: #166029

[sandy081]

Abandoning this PR in favour of the other, as I did not realise this did not get merged.