Switch from setupCustomHover to hoverService #166500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref #159088 By switching to hoverService, we get to customize the hover widget more for the Settings editor indicators.
rzhao271
force-pushed
the
rzhao271/sei-remove-setupcustomhover
branch
from
10fe16b
to
dd01fd8
Compare
|
After this PR, there's still hover focus to fix, as well as getting the left/right keys to work with the indicators. |
roblourens
approved these changes
Nov 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #159088
By switching to hoverService, we get to customize the hover widget
more for the Settings editor indicators.
The PR also adds keydown handlers and tabIndexes for the indicators so that one can focus onto an indicator and then press a key such as Enter to show the hover.