Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtle borders to widgets #167773

Merged
merged 8 commits into from
Dec 13, 2022
Merged

Add subtle borders to widgets #167773

merged 8 commits into from
Dec 13, 2022

Conversation

daviddossett
Copy link
Contributor

@daviddossett daviddossett commented Nov 30, 2022

This helps separate elevated widgets from main UI layer and moves them to be consistent with the menu look & feel updates from #164165

  • Adds widgetBorder and applies to quick input, find, debug, feedback, notifications, and more.

CleanShot 2022-12-13 at 10 10 25@2x

CleanShot 2022-12-13 at 10 08 27@2x

CleanShot 2022-12-13 at 10 08 42@2x

CleanShot 2022-12-01 at 11 14 20@2x

CleanShot 2022-12-01 at 11 14 25@2x

@daviddossett daviddossett changed the title Add border to quick pick to match menus Add borders to various widgets Dec 1, 2022
tsr-images
tsr-images previously approved these changes Dec 1, 2022
@daviddossett daviddossett marked this pull request as ready for review December 5, 2022 16:54
@daviddossett daviddossett changed the title Add borders to various widgets Add subtle borders to widgets Dec 5, 2022
amunger
amunger previously approved these changes Dec 5, 2022
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the notifications look fantastic, I'm not sure about the other cases like the rename/find widget though. This deserves discussion in the UX sync imo

@daviddossett daviddossett merged commit fe64650 into main Dec 13, 2022
@daviddossett daviddossett deleted the ddossett/popular-rhinoceros branch December 13, 2022 18:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants