-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subtle borders to widgets #167773
Merged
Merged
Add subtle borders to widgets #167773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddossett
changed the title
Add border to quick pick to match menus
Add borders to various widgets
Dec 1, 2022
tsr-images
previously approved these changes
Dec 1, 2022
daviddossett
changed the title
Add borders to various widgets
Add subtle borders to widgets
Dec 5, 2022
amunger
previously approved these changes
Dec 5, 2022
Tyriar
requested changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the notifications look fantastic, I'm not sure about the other cases like the rename/find widget though. This deserves discussion in the UX sync imo
daviddossett
dismissed stale reviews from amunger and tsr-images
via
December 13, 2022 18:03
f3d09b3
Tyriar
approved these changes
Dec 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps separate elevated widgets from main UI layer and moves them to be consistent with the menu look & feel updates from #164165
widgetBorder
and applies to quick input, find, debug, feedback, notifications, and more.