Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicely format logged objects #179405

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Nicely format logged objects #179405

merged 1 commit into from
Apr 11, 2023

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Apr 6, 2023

Follow up oin #176479 (comment)

This uses JSON.stringify to format objects that are logged. Currently they are all printed as a single line without any whitespace

Follow up oin microsoft#176479 (comment)

This uses JSON.stringify to format objects that are logged. Currently they are all printed as a single line without any whitespace
@mjbvz mjbvz requested a review from sandy081 April 6, 2023 17:29
@mjbvz mjbvz self-assigned this Apr 6, 2023
@vscodenpa vscodenpa added this to the April 2023 milestone Apr 6, 2023
@mjbvz mjbvz merged commit 5d3f960 into microsoft:main Apr 11, 2023
@sandy081
Copy link
Member

@mjbvz It seems this is not helping in other cases and probably not intended. For eg: Shared process log is not readable with this. Can we please revert this and think about another solution ?

@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 13, 2023

@sandy081 I will revert this and open a new issue

What as the issue with the shared process? That's it's too verbose now? The left side of this screen shot shows what it looked like before this PR, and the right shows it after:

Screenshot 2023-04-13 at 10 33 20 AM

The new version is more readable IMO but takes up more lines in the log

mjbvz added a commit to mjbvz/vscode that referenced this pull request Apr 13, 2023
mjbvz added a commit that referenced this pull request Apr 13, 2023
@sandy081
Copy link
Member

What as the issue with the shared process? That's it's too verbose now? The left side of this screen shot shows what it looked like before this PR, and the right shows it after:

Agreed that a given line is readable but not the complete log as I have to scroll to read more data and most of the times I am not interested in that specific line.

@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 17, 2023

@sandy081 Could we implement folding in the log output channel and fold logged objects by default?

@sandy081
Copy link
Member

May be, but I do not know how trivial it is.

@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants