-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nicely format logged objects #179405
Nicely format logged objects #179405
Conversation
Follow up oin microsoft#176479 (comment) This uses JSON.stringify to format objects that are logged. Currently they are all printed as a single line without any whitespace
@mjbvz It seems this is not helping in other cases and probably not intended. For eg: Shared process log is not readable with this. Can we please revert this and think about another solution ? |
@sandy081 I will revert this and open a new issue What as the issue with the shared process? That's it's too verbose now? The left side of this screen shot shows what it looked like before this PR, and the right shows it after: The new version is more readable IMO but takes up more lines in the log |
This reverts commit 5d3f960. Based on comments in microsoft#179405 (comment)
This reverts commit 5d3f960. Based on comments in #179405 (comment)
Agreed that a given line is readable but not the complete log as I have to scroll to read more data and most of the times I am not interested in that specific line. |
@sandy081 Could we implement folding in the log output channel and fold logged objects by default? |
May be, but I do not know how trivial it is. |
Follow up oin #176479 (comment)
This uses JSON.stringify to format objects that are logged. Currently they are all printed as a single line without any whitespace