Enable chat session export/import #182562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
172
to
193
| // export interface ISerializableInteractiveSessionData { | ||
| // sessionId: string; | ||
| // creationDate: number; | ||
| // welcomeMessage: (string | IInteractiveSessionReplyFollowup[])[] | undefined; | ||
| // requests: ISerializableInteractiveSessionRequestData[]; | ||
| // requesterUsername: string; | ||
| // responderUsername: string; | ||
| // requesterAvatarIconUri: UriComponents | undefined; | ||
| // responderAvatarIconUri: UriComponents | undefined; | ||
| // providerId: string; | ||
| // providerState: any; | ||
| // } | ||
|
|
||
| // export interface ISerializableInteractiveSessionRequestData { | ||
| // providerResponseId: string | undefined; | ||
| // message: string; | ||
| // response: string | undefined; | ||
| // responseErrorDetails: IInteractiveResponseErrorDetails | undefined; | ||
| // followups: IInteractiveSessionFollowup[] | undefined; | ||
| // isCanceled: boolean | undefined; | ||
| // vote: InteractiveSessionVoteDirection | undefined; | ||
| // } |
sbatten
previously approved these changes
May 15, 2023
| return; | ||
| } | ||
|
|
||
| const model = interactiveSessionService.getSession(widget.viewModel.sessionId); |
There was a problem hiding this comment.
Doesn't this return an object with like... methods and whatnot? Wouldn't it be better to have a concrete export type that is truly just data?
There was a problem hiding this comment.
It has an implementation of toJSON so it stringifies nicely, if that's what you mean
There was a problem hiding this comment.
The service also returns an interface which gives you readonly access to the model. Only the service is supposed to mutate the model
TylerLeonhardt
previously approved these changes
May 15, 2023
roblourens
force-pushed
the
roblou/uptight-goat
branch
from
8517006
to
06da479
Compare
DonJayamanne
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.