Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimum scrolling to reveal the next cell on shift+enter #183600

Merged
merged 1 commit into from
May 26, 2023

Conversation

amunger
Copy link
Contributor

@amunger amunger commented May 26, 2023

related to #191086

by only scrolling as much as needed, we're less likely to push the previous output off of the screen. This behaves more like jupyter lab.

I think it would be nice to have a setting to keep the focus on the previous cell's output, but that is not currently supported in the reveal API, so making this simple change for now.

@amunger amunger requested a review from rebornix May 26, 2023 21:11
@vscodenpa vscodenpa added this to the May 2023 milestone May 26, 2023
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amunger , this is really nice!

@rebornix rebornix merged commit 397175e into main May 26, 2023
@rebornix rebornix deleted the aamunger/scrollOnExecute branch May 26, 2023 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants