Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uninstall hanging #187015

Closed
wants to merge 1 commit into from
Closed

Fix uninstall hanging #187015

wants to merge 1 commit into from

Conversation

ChaseKnowlden
Copy link
Contributor

Fix #164689.

@alexdima alexdima added this to the July 2023 milestone Jul 10, 2023
deepak1556
deepak1556 requested changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please expand on the change, I am not sure how this resolves the uninstallation hang.

@ChaseKnowlden
Copy link
Contributor Author

ChaseKnowlden commented Jul 16, 2023 •
edited
Loading

There was a typo in the UninstallRun element that wasn't removing the package at all.

@deepak1556 deepak1556 modified the milestones: July 2023, August 2023 Jul 25, 2023
@deepak1556
Copy link
Collaborator

Triggered custom build to verify https://monacotools.visualstudio.com/Monaco/_build/results?buildId=227850&view=results

@deepak1556
Copy link
Collaborator

Inno setup compilation failed with the following error,

2023-08-16T05:23:09.4553478Z Error on line 107 in D:\a\_work\1\s\build\win32\code.iss: Unknown constant "Remove-AppxPackage -Package "Microsoft.VSCodeInsiders_1.0.0.0_neutral__8wekyb3d8bbwe"".
2023-08-16T05:23:09.4553848Z 
2023-08-16T05:23:09.4554151Z Use two consecutive "{" characters if you are trying to embed a single "{" and not a constant.

I remember adding the extra { for the same reason. Closing as the change does not solve the mentioned issue. Thanks for working on it!

@deepak1556 deepak1556 closed this Aug 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepak1556 deepak1556 deepak1556 requested changes

@0x4248 0x4248 0x4248 approved these changes

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
August 2023
Development

Successfully merging this pull request may close these issues.

Uninstalling VS Code takes a long time, when enabling the Windows 11 context menu action
4 participants
@ChaseKnowlden @deepak1556 @0x4248 @alexdima