Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: Throttler is disposed in serve-web #191624

Closed
Igorgro opened this issue Aug 29, 2023 · 2 comments
Closed

Error: Throttler is disposed in serve-web #191624

Igorgro opened this issue Aug 29, 2023 · 2 comments
Assignees
@bpasero
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug file-io File I/O file-watcher File watcher insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
September 2023

Comments

@Igorgro
Copy link

Igorgro commented Aug 29, 2023

Testing #191542

  • VS Code Version:
    Version: 1.82.0-insider
    Commit: ebd6724
    Date: 2023-08-29T05:03:17.701Z
    Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36

  • OS Version: Arch Linux

Steps to Reproduce:

  1. Download latest insider vscode cli
  2. Run code-insider serve-web , open the browser and wait for vscode server to open
  3. Open and close some workspaces and folders
  4. The following error lines appear in terminal where cli is run:
[2023-08-29 16:57:20] info [ebd6724 stderr]: [16:57:20] Error: Throttler is disposed
[2023-08-29 16:57:20] info [ebd6724 stderr]:     at c.queue (/<path-to-vscode-cli>/cli/serve-web/ebd67244fb2da33ab078bb2baa96106fda29f336/out/vs/server/node/server.main.js:70:13632)
[2023-08-29 16:57:20] info [ebd6724 stderr]:     at /<path-to-vscode-cli>/cli/serve-web/ebd67244fb2da33ab078bb2baa96106fda29f336/out/vs/server/node/server.main.js:70:15216
[2023-08-29 16:57:20] info [ebd6724 stderr]:     at /<path-to-vscode-cli>/cli/serve-web/ebd67244fb2da33ab078bb2baa96106fda29f336/out/vs/server/node/server.main.js:70:14852
[2023-08-29 16:57:20] info [ebd6724 stderr]:     at runNextTicks (node:internal/process/task_queues:60:5)
[2023-08-29 16:57:20] info [ebd6724 stderr]:     at listOnTimeout (node:internal/timers:538:9)
[2023-08-29 16:57:20] info [ebd6724 stderr]:     at process.processTimers (node:internal/timers:512:7)
@thekeith
Copy link

@Igorgro I have seen the same behavior as well. When it occurs, the VSCode window will go unresponsive for a moment and then reload.

@ulugbekna ulugbekna assigned connor4312 and unassigned ulugbekna Sep 5, 2023
@connor4312 connor4312 added the bug Issue identified by VS Code Team member as probable bug label Sep 5, 2023
@connor4312 connor4312 mentioned this issue Sep 5, 2023
Closed
connor4312 added a commit that referenced this issue Sep 5, 2023
@connor4312
fs: fix 'throttler is disposed' on disconnect
2ead2dd 
Fixes #191624
@bpasero bpasero assigned bpasero and unassigned connor4312 Sep 6, 2023
@bpasero bpasero added file-watcher File watcher file-io File I/O labels Sep 6, 2023
@bpasero bpasero added this to the September 2023 milestone Sep 6, 2023
@bpasero bpasero closed this as completed in db2ae1d Sep 7, 2023
bpasero added a commit that referenced this issue Sep 7, 2023
@bpasero
Merge pull request #192378 from microsoft/ben/bare-newt
bb389f2 
Error: Throttler is disposed in serve-web (fix #191624)
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 7, 2023
@bpasero bpasero added the author-verification-requested Issues potentially verifiable by issue author label Sep 8, 2023
@vscodenpa
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@Igorgro, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version e073d67 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@roblourens roblourens added the verified Verification succeeded label Sep 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug file-io File I/O file-watcher File watcher insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
September 2023
Development

Successfully merging a pull request may close this issue.

fs: fix 'throttler is disposed' on disconnect microsoft/vscode
7 participants
@roblourens @thekeith @bpasero @connor4312 @ulugbekna @Igorgro @vscodenpa