Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug test cleanup #192503

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Debug test cleanup #192503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20cdb30
Fix #192430
roblourens Sep 7, 2023
c07e447
Fix Debug ANSI tests that don't pass when run on their own
roblourens Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/vs/workbench/contrib/debug/test/browser/debugANSIHandling.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { LinkDetector } from 'vs/workbench/contrib/debug/browser/linkDetector';
import { DebugModel } from 'vs/workbench/contrib/debug/common/debugModel';
import { createTestSession } from 'vs/workbench/contrib/debug/test/browser/callStack.test';
import { createMockDebugModel } from 'vs/workbench/contrib/debug/test/browser/mockDebugModel';
import { ansiColorMap } from 'vs/workbench/contrib/terminal/common/terminalColorRegistry';
import { ansiColorMap, registerColors } from 'vs/workbench/contrib/terminal/common/terminalColorRegistry';
import { workbenchInstantiationService } from 'vs/workbench/test/browser/workbenchTestServices';

suite('Debug - ANSI Handling', () => {
Expand Down Expand Up @@ -45,6 +45,7 @@ suite('Debug - ANSI Handling', () => {
}
const testTheme = new TestColorTheme(colors);
themeService = new TestThemeService(testTheme);
registerColors();
});

teardown(() => {
Expand Down
2 changes: 2 additions & 0 deletions src/vs/workbench/contrib/debug/test/common/debugModel.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ suite('DebugModel', () => {
const wholeStackDeferred = new DeferredPromise<void>();
const fakeThread = mockObject<Thread>()({
session: { capabilities: { supportsDelayedStackTraceLoading: true } } as any,
getCallStack: () => [],
getStaleCallStack: () => [],
});
fakeThread.fetchCallStack.callsFake((levels: number) => {
return levels === 1 ? topFrameDeferred.p : wholeStackDeferred.p;
Expand Down
Loading