fire active, inactive before, after lines are processed for reconnected task terminals #192925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
previously requested changes
Sep 12, 2023
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Tyriar
approved these changes
Sep 12, 2023
lins0621
pushed a commit
to lins0621/vscode
that referenced
this pull request
Sep 14, 2023
fire active, inactive before, after lines are processed for reconnected task terminals
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aligns with what we do when the lines are processed via the watching problem collector vs our reconnection.
fix #192921
also fixes the case where the task is run on folder open before the full task reconnection happens