Fix no common properties when logging error by aligning 'properties' contract

[Joouis]

• Aossicated issue: Missing common properties in extension telemetry when logging error event Missing common properties in extension telemetry when logging error event #193205
• Ensure that the code is up-to-date with the main branch: will update the branch after approvals
• Description:
  • Please check the issue mentioned above firstly to understand the motivation of this PR.
  • The root cause of missing common properties when logging error is that the data structure is not uniform when mixing common props in. No matter "properties" is in or not in data object, I think the function should keep the same structure for the downstream functions instead of two different looks. The telemetry extension follows the API contract from App Insights package to pass "properties" and "measurements" accordingly, if common properties are not in the "properties" then the bug triggered.
  • This is the expected log screenshot by this change.
    

[Joouis]

It's strange that telemetry will not be sent in Code - OSS, the development way is like open Code - OSS by yarn watch, then open my extension project by Code - OSS process, debug my extension to open another Code -OSS process. One VSCode and two Code - OSS windows opened at same time, this could be a little bit complex. And my workaround steps are:

1. Throw an error in my extension code and print the data from mixInCommonPropsAndCleanData() in Code - OSS
2. Starting the debug mode of VSCode and set break point at the beginning of sendErrorData() internally
3. Throw an error in my extension code again to trigger the break point, then replace the data value passed to sendErrorData() by the printed data in step 1.

Finally I can check the data on App Insights. @lramos15 any idea for this? Thanks :)

[lramos15]

Seems like the CI is failing due to telemetry tests failing

[Joouis]

Yes I'm looking into it.

[Joouis]

Hi @aeschli, I haven't heard back from Logan in two weeks, could you help on the PR? I think #193205 affects all customers that no common properties for "unhandlederror" type, making anlysis harder like from which extension version the bug begins.

[aeschli]

@Joouis Sorry, we need Logan for this..

[Joouis]

So kindly ping @lramos15 again.

[lramos15]

So kindly ping @lramos15 again.

I'm aware of this PR, but am a bit swamped at the moment with some other work. Thank you for your patience 🙏