Hoverservice has it's own contextview instance #206151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
requested changes
Feb 25, 2024
This comment was marked as spam.
This comment was marked as spam.
Yes and no. It will work if you open a context view (using context view service) and then have a hover in that context view which uses the hover service. For example breadcrumbs context view. The Zoom control is a hover and so this would not work. I had a quick go at implementing a hover stack, supporting hovers in hovers in hovers ... However, this is rather complicated to get working well with the current implementation of hovers and so would take a while to properly design if needed. |
bpasero
approved these changes
Feb 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows features such as breadcrumbs to work