Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statusbar - support more than 2 items in a group #216605

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

lszomoru
Copy link
Member

Fixes #214918

@lszomoru lszomoru added the workbench-status Status bar label Jun 19, 2024
@lszomoru lszomoru added this to the June 2024 milestone Jun 19, 2024
@lszomoru lszomoru requested a review from bpasero June 19, 2024 10:30
@lszomoru lszomoru self-assigned this Jun 19, 2024
@lszomoru lszomoru enabled auto-merge (squash) June 19, 2024 10:30
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this fixes the positioning, but the UI is not entirely fit for more than one neighbour group:

Recording 2024-06-19 at 19 58 50

Filed #216637 for that

@lszomoru lszomoru merged commit 5c1b006 into main Jun 19, 2024
6 checks passed
@lszomoru lszomoru deleted the lszomoru/insufficient-hare branch June 19, 2024 18:33
bricefriha pushed a commit to bricefriha/vscode that referenced this pull request Jun 26, 2024
* Statusbar - support more than 2 items in a group

* 💄

* some 💄

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SourceControl.statusBarCommands - third and subsequent commands are detached from first two
3 participants