Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window title use execution path. #221258

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Window title use execution path. #221258

merged 1 commit into from
Jul 11, 2024

Conversation

tisilent
Copy link
Contributor

@tisilent tisilent commented Jul 9, 2024

fix #220129
Unable to reproduce #6590,the problem is somewhat similar to #60806.
To be conservative, use the execution path to assign a title.
I feel that removing it is also possible.
11

@vscodenpa vscodenpa added this to the July 2024 milestone Jul 11, 2024
@Tyriar Tyriar enabled auto-merge July 11, 2024 23:15
@Tyriar Tyriar merged commit 5f6b6a8 into microsoft:main Jul 11, 2024
6 checks passed
@tisilent tisilent deleted the fix-#220129 branch July 12, 2024 00:59
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terminal.external.windowsExec not work as expected when path contains spaces
4 participants