Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Panel Maximize when at top but not center-aligned #221549

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #221547

@gjsjohnmurray
Copy link
Contributor Author

Pinging @benibenj as the current iteration plan shows you responsible for landing this feature.

@benibenj
Copy link
Contributor

Thank you very much for fixing this @gjsjohnmurray

@vscodenpa vscodenpa added this to the July 2024 milestone Jul 17, 2024
@benibenj benibenj assigned benibenj and unassigned sbatten Jul 17, 2024
@gjsjohnmurray
Copy link
Contributor Author

Thank you very much for fixing this @gjsjohnmurray

@benibenj glad to be able to help. Please merge this now it's received the second approval.

@benibenj benibenj merged commit 2c1c33c into microsoft:main Jul 17, 2024
6 checks passed
@gjsjohnmurray gjsjohnmurray deleted the fix-221547 branch July 17, 2024 13:40
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top-positioned Panel that isn't center aligned offers Maximize button
5 participants