Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop AutoInstallerFs from thrashing forevermore and fix typings installer #225648

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

zkat
Copy link
Member

@zkat zkat commented Aug 14, 2024

This gets the AutoInstallerFs and ATA working. Previously, it was thrashing like whoa, but now only a single package management operation is done at a time, and the thundering herd just waits for that one shared operation to complete, instead of queueing new ones.

The only thing I can't seem to get this to do is to re-install and refresh types/definitions when package.json changes or when a new dependency is imported. Not sure what's up with that, but I think that problem can be solved separately.

/cc @mattbierner

@zkat zkat changed the title stop AutoInstallerFs from thrashing forevermore stop AutoInstallerFs from thrashing forevermore and fix typings installer Aug 15, 2024
Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for taking a look

@vs-code-engineering vs-code-engineering bot added this to the August 2024 milestone Aug 15, 2024
@mjbvz mjbvz merged commit d751e43 into microsoft:main Aug 16, 2024
6 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants