Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #76561 #76598

Merged
merged 1 commit into from Jul 5, 2019

Conversation

Projects
None yet
2 participants
@bpasero
Copy link
Member

commented Jul 4, 2019

Avoid having the same status bar contribution priority.

@isidorn

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

The change looks good you are no longer clashing with the priority of 50 defined here
https://github.com/Microsoft/vscode/blob/7c88e07cc69633729be10d25e8408707fce48bf4/src/vs/workbench/contrib/markers/browser/markers.contribution.ts#L280

@bpasero However what are the repro steps for this? I just want to verify all is good.

@bpasero

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

@isidorn :

  • install extensions from #76561 (comment)
  • multi root workspace
  • open a file
  • run build task
  • click on scm providers

Eventually I got the broken state because each click on a repo redraws the SCM one.

@isidorn

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

I can reproduce without your fix.
I can not reproduce with your fix. So all looks good -> approved.

@isidorn

isidorn approved these changes Jul 4, 2019

@bpasero bpasero merged commit 3a4ba8b into release/1.36 Jul 5, 2019

6 checks passed

VS Code Build #20190704.40 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
VS Code Distro Sync & Merge Check #20190704.20 succeeded
Details
license/cla All CLA requirements met.

@bpasero bpasero deleted the ben/fix-76561 branch Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.