Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #76561 #76598

Merged
merged 1 commit into from
Jul 5, 2019
Merged

fix #76561 #76598

merged 1 commit into from
Jul 5, 2019

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jul 4, 2019

Avoid having the same status bar contribution priority.

@isidorn
Copy link
Contributor

isidorn commented Jul 4, 2019

The change looks good you are no longer clashing with the priority of 50 defined here
https://github.com/Microsoft/vscode/blob/7c88e07cc69633729be10d25e8408707fce48bf4/src/vs/workbench/contrib/markers/browser/markers.contribution.ts#L280

@bpasero However what are the repro steps for this? I just want to verify all is good.

@bpasero
Copy link
Member Author

bpasero commented Jul 4, 2019

@isidorn :

Eventually I got the broken state because each click on a repo redraws the SCM one.

@isidorn
Copy link
Contributor

isidorn commented Jul 4, 2019

I can reproduce without your fix.
I can not reproduce with your fix. So all looks good -> approved.

@bpasero bpasero merged commit 3a4ba8b into release/1.36 Jul 5, 2019
@bpasero bpasero deleted the ben/fix-76561 branch July 5, 2019 13:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants